Skip to content

Add support for CSAF field - #93

Merged
joker314 merged 2 commits into
securitytxt:masterfrom
tschmidtb51:csaf_support
Jun 30, 2023
Merged

joker314 merged 2 commits into
securitytxt:masterfrom
tschmidtb51:csaf_support

Conversation

@tschmidtb51

Copy link
Copy Markdown
Contributor

fixes #92

@EdOverflow

Copy link
Copy Markdown
Member

Thank you for the pull request, @tschmidtb51. This looks good to me but I will wait for @joker314 to review this if they get a chance just to make sure.

@joker314

Copy link
Copy Markdown
Contributor

Will review later today, but it looks good

@joker314
joker314 self-requested a review April 11, 2023 00:08

@joker314 joker314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the YAML are correct and look good. 👍 Thank you for submitting it.

The way the form currently works is that the field names have to be listed once more in the JavaScript in order for them to be included in the output.

generate('security.txt', [
"contact", "expires", "encryption", "acknowledgments", "preferredLanguages", "canonical", "policy", "hiring"
]);

However, the existing code converts camel case into hyphens, but we don't want that here (it would lead to C-S-A-F: instead of CSAF:). In the short term we could special-case the CSAF field, but I think it would be better to update the JS so this problem does not occur in the future. I will make that update in the next few days, and then we can merge this PR.

@tschmidtb51

Copy link
Copy Markdown
Contributor Author

@joker314 Sorry for the long radio silence. I added the id csaf to be included in the output.

@tschmidtb51

Copy link
Copy Markdown
Contributor Author

@joker314 I created #95 as replacement if you want the short term hack.

@joker314
joker314 merged commit f805865 into securitytxt:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CSAF field

3 participants