Add validation to Contact field - #81
Merged
Merged
Conversation
|
IMHO a god usability would be, if I enter After all, the advantage of this website is to simplify things, and I as a user should not worry about the exact syntax… |
Contributor
@joker314 can you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix, and it may be a good idea to follow up with a more long-term solution to validation.
The above message appears as the user is typing. If the user chooses to submit despite the warning, the input box regains focus (thus scrolling them so that the input box is on screen), the security.txt file is not generated, and an additional red box appears at the top.
The red box does not disappear until the user submits the form again, even after they have corrected all the issues.
Note: the validation only checks that the input begins with
https://,mailto:ortel:. It does not validate the content afterwards (such as whether there is an@ifmailto:is used) but this can potentially be added in a follow-up PR.