Use RFC 3339/ISO 8601 in generating form - #76
Merged
Merged
Conversation
joker314
marked this pull request as ready for review
April 16, 2021 18:07
Contributor
Author
|
That other work can be left for later, I think it's ok to undraft this PR. Should it be merged after the new draft is submitted and published by the IETF? |
This was referenced May 24, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specification has been updated with respect to the format for which dates and times should be outputted in the
Expiresfield.This pull request can therefore take advantage of JavaScript's built in
.toISOString()to format the date..toISOSting()always uses UTC for its timezone. This behaviour is different to the old version of the form, which would use the local timezone of the user. I think that this change is fine but mayExpiresfieldsResolves #75