Add 'Expires' to security.txt genform - #51
Conversation
|
I've merged in the changes from #68. Then, I added some
I then used Liquid to automatically choose between the currently displayed message (if the two version numbers don't match), or this new green message if they do match The image reads
The hyperlink opens in a new tab. The idea is that in the future, we will quickly be able to update the website to show the warning notice if there is a change to the Internet draft - this is just an update to the YAML so will not require too much thought. See commit d1dc488 for an example (lines 75-85) of how to fill in the |
|
I've now fixed an issue where the outputted date format was not compliant with RFC 5322. I've also added the weekday. An example output now looks like this: This omits seconds, but they are optional anyway. The time is just the value of the HTML time input. It's possible to get the HTML time input to include seconds, but this seems unnecessary and there seem to be some browser quirks with it. I've also refactored to remove the hard coding of the month names. This should now be ready to review 👍 |
|
Thank you, @joker314! |


Resolves #41
Here is what it would look like if you're using a browser which doesn't support
dateortimeinputs. An example of such a browser is Safari fortime, or Internet Explorer for both (although in this PR I've decided to write JS which does not support IE):This is what it looks like for most modern browsers (the date format will be locale-sensitive):
Where clicking on the appropriate icons will bring up the browser's calendar or time UI.
The two inputs are set to 'required' but there's currently no validation otherwise. If you're using a modern browser, there's not really a way of inputting an invalid date; but if you're using the text versions then you could mess it up completely. We'll add validation for all the fields in another PR soon.
This PR should be good to merge 👍