Skip to content

Make minor improvements to the README.md file - #35

Merged
EdOverflow merged 2 commits into
securitytxt:masterfrom
joker314:fix/readme
Mar 10, 2019
Merged

EdOverflow merged 2 commits into
securitytxt:masterfrom
joker314:fix/readme

Conversation

@joker314

@joker314 joker314 commented Mar 9, 2019

Copy link
Copy Markdown
Contributor

This pull request makes two changes:

  • a4b201e Give the top image some alternative text. The image adds value to the document by explaining that the repository concerns a website that details a way for websites to define a security policy. This information replaces the less descriptive previous alt attribute of "image"
  • 5cf6259 Resolves a potential security-related issue. In particular, it resolves the security issue of reverse tabnabbing. In this particular case, the issue is not exploitable since GitHub ignores the request that the link open in a new tab; and markdown files do not usually open locally in the browser. To comply with best practices, we fix it anyway.

@EdOverflow
EdOverflow merged commit 4010af5 into securitytxt:master Mar 10, 2019
@joker314
joker314 deleted the fix/readme branch March 10, 2019 12:21
joker314 added a commit to joker314/securitytxt.org that referenced this pull request Apr 7, 2019
Note that there was never any security impact. See securitytxtgh-35 (the second commit of which resolved the initial reverse tabnabbing issue). That pull request discusses why this isn't a security problem in most circumstances. This change is made simply to conform to best practices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants