Don't automatically save generated file to clipboard - #28
Merged
Merged
Conversation
Contributor
Author
|
Alright, I've added changes in 8eb8d28 which should keep the website compatible with very old browsers. |
Member
|
Thank you, @joker314. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes
twothree changes:I looked at the level of support for
scrollIntoView. Most browsers support it when the first argument is a Boolean. However, I'm passing an object so that the scrolling is smooth. I think it is very likely (but am not certain) that these older browsers will still scroll the element into view, even if they don't scroll smoothly.I haven't added anything to handle browsers which don't support8eb8d28 will use the hash component of URLs to scroll to the relevant location as a fallback.scrollIntoView. Should I? (I'd be happy to do so)