Skip to content

Bump draft links to -05, and use the new directives - #25

Merged
nightwatchcyber merged 9 commits into
securitytxt:masterfrom
joker314:fix/links
Jan 16, 2019
Merged

nightwatchcyber merged 9 commits into
securitytxt:masterfrom
joker314:fix/links

Conversation

@joker314

@joker314 joker314 commented Jan 13, 2019

Copy link
Copy Markdown
Contributor

All the links were pointing to the -04 draft. However, the -05 draft has been published

Hence, update all those links. I used a regular expression matching for "-04" to do this.

In addition, make the following changes:

  • Change the form for generating security.txt files so that it lists the new version of the directives
  • Use more succint notation in the JavaScript
  • Expand the camelCase -> directive converter to be able to handle multiple words
  • Use the var keyword to ensure variables stay in their scope only

@joker314

Copy link
Copy Markdown
Contributor Author

Oh and we need to add/remove some of the directives!

@joker314 joker314 changed the title Bump draft links to -05 Bump draft links to -05, and use the new directives Jan 13, 2019
Also, update the example to use hall-of-fame because that provides extra context which could help someone understand what they're supposed to put there.
@joker314

Copy link
Copy Markdown
Contributor Author

Okay, I've updated all the directives and the links, and also changed the JavaScript a little. It should all still work in IE9+ (as before), but I haven't tested.

I think we should add some validation (e.g., make Contact a required field, and explain to the user if they fail to complete it). I'll file an issue for it.

@EdOverflow

Copy link
Copy Markdown
Member

Thank you very much, @joker314. It turns out you can simply link to https://tools.ietf.org/html/draft-foudil-securitytxt and the user will be redirected to the latest draft. :)

@joker314

Copy link
Copy Markdown
Contributor Author

Thanks @EdOverflow, that's super cool, so I've updated to the special links so that we'll have less work in future.

Comment thread index.html Outdated

@nightwatchcyber nightwatchcyber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor issue needs to be fixed, otherwise I think this is good

@nightwatchcyber
nightwatchcyber merged commit b8ea37c into securitytxt:master Jan 16, 2019
@joker314
joker314 deleted the fix/links branch January 16, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants