Skip to content

Remove SRI hash from Google fonts. - #2

Merged
tomnomnom merged 1 commit into
masterfrom
sri-hash
Oct 5, 2017
Merged

tomnomnom merged 1 commit into
masterfrom
sri-hash

Conversation

@EdOverflow

Copy link
Copy Markdown
Member

Since Google fonts are dynamic we cannot use SRI hashes.

@EdOverflow
EdOverflow requested a review from tomnomnom October 5, 2017 13:12
@EdOverflow EdOverflow added the bug label Oct 5, 2017
@tomnomnom
tomnomnom merged commit 003e3cc into master Oct 5, 2017

@tomnomnom tomnomnom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me 👍

You could re-host the fonts in this repo ensure consistency if you really wanted (and to avoid the extra DNS lookup/TCP connection); but that sounds like a lot of faff, doesn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants