Languages updates for the draft text - #66
Merged
Merged
Conversation
nightwatchcyber
requested changes
Dec 31, 2017
nightwatchcyber
left a comment
nightwatchcyber
left a comment
Contributor
There was a problem hiding this comment.
One small comment, and also can you regenerate the TXT and HTML versions, add that to the pull req?
Thanks!
| of using the <SECURITY@domain> email address for communications regarding | ||
| security issues. That convention provides only a single, email-based | ||
| channel of communication for security issues per domain, and does not provide | ||
| a channel of communication for security issues per domain, and does not provide |
Contributor
There was a problem hiding this comment.
I think this "a" is extra, there is one on the line above
Member
|
Sorry @nightwatchcyber, I forgot to notify you that I instructed @martijnrusschen not to install all the dependencies and that I would generate the text and HTML files for them. |
Contributor
|
@EdOverflow and @martijnrusschen - my apoligizes, I wasn't aware of that. I am going to add a new issue to the project to enable automatic regeneration of the TXT and HTML versions via a CI system like I have seen other projects do. see: |
Author
|
Thanks, good catch! |
nightwatchcyber
approved these changes
Dec 31, 2017
Contributor
|
@EdOverflow @martijnrusschen Looks good |
EdOverflow
requested changes
Dec 31, 2017
| ~~~~~~~~~~ | ||
|
|
||
| Example security acknowledgements page: | ||
| Example security acknowledgments page: |
Member
There was a problem hiding this comment.
This does not adhere to the directive (Acknowledgement:).
EdOverflow
requested changes
Jan 6, 2018
| field = contact-field / | ||
| encryption-field / | ||
| acknowledgement-field / | ||
| Acknowledgments-field / |
Member
There was a problem hiding this comment.
s/Acknowledgments-field/acknowledgments-field
EdOverflow
added a commit
that referenced
this pull request
Jan 7, 2018
* updated issues shield/link * Remove hero image. * Create draft-foudil-securitytxt-01.txt. * Create draft-foudil-securitytxt-01.txt. * chore(text): fix grammar * chore(text): fix grammar * Fix Typo * Fix Typo * Fix Shield Link * Fix Shield Link * converting to use markdown and adding IETF tool support * clarifying instructions for making the text draft * putting back the original version * adding version-01 before markdown conversion * adding text draft generated from markdown * removing non-markdown draft version * Adding IANA registration for .well-known * removing date * Adding IANA registry for extensibility to address issue #34 * added extensibility section * adding extensibility to abnf * Start working on https://github.com/securitytxt/security-txt/milestone/2. * Add Signature directive to registry. * Add file location section. * Explaining how this is different from RFC2142 * language tweaks * s/filesystems/file systems * adding author * adding html * adding txt and html * re-generating drafts * Signature file should be added to the Well-Known URI's registry In accordance with issue #59, the signature file "security.txt.sig" should also be added to the Well-Known URI's registry. * Update draft-01. * Update draft. * s/draft-01/draft-02 * Adding history section, and addressing issues #55 and #14 * Adding language to clarify Contact values as per issue #62 * "the" ability * Create .travis.yml * Languages updates for the draft text (#66) * Languages updates for the draft text * Fix comment * Fix more wording * Fix for Ed
EdOverflow
added a commit
that referenced
this pull request
Jan 15, 2018
* updated issues shield/link * Remove hero image. * Create draft-foudil-securitytxt-01.txt. * Create draft-foudil-securitytxt-01.txt. * chore(text): fix grammar * chore(text): fix grammar * Fix Typo * Fix Typo * Fix Shield Link * Fix Shield Link * converting to use markdown and adding IETF tool support * clarifying instructions for making the text draft * putting back the original version * adding version-01 before markdown conversion * adding text draft generated from markdown * removing non-markdown draft version * Adding IANA registration for .well-known * removing date * Adding IANA registry for extensibility to address issue #34 * added extensibility section * adding extensibility to abnf * Start working on https://github.com/securitytxt/security-txt/milestone/2. * Add Signature directive to registry. * Add file location section. * Explaining how this is different from RFC2142 * language tweaks * s/filesystems/file systems * adding author * adding html * adding txt and html * re-generating drafts * Signature file should be added to the Well-Known URI's registry In accordance with issue #59, the signature file "security.txt.sig" should also be added to the Well-Known URI's registry. * Update draft-01. * Update draft. * s/draft-01/draft-02 * Adding history section, and addressing issues #55 and #14 * Adding language to clarify Contact values as per issue #62 * "the" ability * Create .travis.yml * Start working on securitytxt-03. * Update version to 03. * Fix mistakes. * Languages updates for the draft text (#66) * Languages updates for the draft text * Fix comment * Fix more wording * Fix for Ed * Update securitytxt-03 addressing the issues raised by @nightwatchcyber. * Fix remaining issues. * Solve #77: Add language about security researcher's responsibility. * Solve #87.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some minor edits to improve the language.