Make changes to the ABNF grammar for non-chainable directives - #151
Merged
Merged
Conversation
Contributor
Author
|
I noticed that in the ABNF for ABNF, two spaces are placed after the equals sign so that everything lines up. However, for the URI ABNF (https://tools.ietf.org/html/rfc3986#appendix-A), instead of using Which option should we use in order to keep things aligned? |
Contributor
|
I think two spaces should work The other change is good "=/" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #150
This pull request adds:
Questions:
*line *line. This, I think, will lead to a parsing ambiguity (i.e., which*linegobbles up more of the lines?), and is that bad (and is it avoidable)?make txt, indentation for the ABNF section was lost. This is probably caused by a different version of the relevant tools, should I manually go in and re-indent all of the ABNF?