Redirects and security considerations (#143 and #112) - #146
Conversation
nightwatchcyber
commented
Feb 19, 2019
- Added language handling redirects (Add language to address redirects and edge cases #143)
- Expanded security considerations section (Allow to mark properties that do not allow security testing ("Permission") #30, Expand security considerations section to explain parsing issues #73, Encryption and signature schemes not specified; hijacking #103, Create a threat model for security.txt. #112)
joker314
left a comment
There was a problem hiding this comment.
I really like the changes introduced in this pull request, all the changes are very well-written!
I noticed a few typos and thought I'd gather them as a review.
|
@joker314 - I updated the pull req with fixes, please review Thanks |
joker314
left a comment
There was a problem hiding this comment.
Thank you for taking the time to make all those changes! It looks like you didn't "build" the security.txt file to get all the other file formats to have the same changes... I'm not familiar with the process but thought I'd point it out, just in case.
After your latest changes, I only found one typo. Everything looks great otherwise!
|
Should be fixed now To regenerate the draft I usually run "make clean txt html" |
joker314
left a comment
There was a problem hiding this comment.
Thanks for making all the changes!