Skip to content

Redirects and security considerations (#143 and #112) - #146

Merged
nightwatchcyber merged 7 commits into
securitytxt:masterfrom
nightwatchcyber:master
Mar 13, 2019
Merged

nightwatchcyber merged 7 commits into
securitytxt:masterfrom
nightwatchcyber:master

Conversation

@joker314 joker314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the changes introduced in this pull request, all the changes are very well-written!

I noticed a few typos and thought I'd gather them as a review.

Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
@nightwatchcyber

Copy link
Copy Markdown
Contributor Author

@joker314 - I updated the pull req with fixes, please review

Thanks

@joker314 joker314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to make all those changes! It looks like you didn't "build" the security.txt file to get all the other file formats to have the same changes... I'm not familiar with the process but thought I'd point it out, just in case.

After your latest changes, I only found one typo. Everything looks great otherwise!

Comment thread draft-foudil-securitytxt.md Outdated
@nightwatchcyber

Copy link
Copy Markdown
Contributor Author

Should be fixed now

To regenerate the draft I usually run "make clean txt html"

@joker314 joker314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all the changes!

Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
Comment thread draft-foudil-securitytxt.md Outdated
@nightwatchcyber
nightwatchcyber merged commit 7ac2423 into securitytxt:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants