Docker improvement: create volume for caching ui and actix binaries. - #9
Merged
Merged
Conversation
resnickmicah
left a comment
resnickmicah
left a comment
Collaborator
There was a problem hiding this comment.
I didn't have a chance to run it because I'm out on vacation and only have my dinky little macbook that can't handle docker, but it looks good to me!
resnickmicah
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we bind EVERYTHING under
../to/appthis is expensive, especially on mac os, which leads to longer compile times.This fixes that by creating volumes for both the UI and actix-web to keep its cached compiled binaries.